[patch] debug print displays wrong server sid/uid as client sid/uid was :bug with 5 code lines

Ralf Habacker ralf.habacker at freenet.de
Sat Nov 21 00:52:59 PST 2009


Ralf Habacker schrieb:
> <snip>
>>  else
>>    {
>>      if 
>> (_dbus_credentials_include(our_identity,DBUS_CREDENTIAL_WINDOWS_SID))
>>          _dbus_verbose ("Client authorized as SID '%s'"
>>                         " but our SID is '%s', disconnecting\n",
>>                         _dbus_credentials_get_windows_sid(our_identity),
>>                         _dbus_credentials_get_windows_sid(our_identity));
>>     else
>>
>>      _dbus_transport_disconnect (transport);
>>      allow = FALSE;
>>
>> BTW: The code shows also a bug - for the client the server sid is also 
>> printed. I found this bug in all available dbus implementations and 
>> should be fixed -> patch will follow
>>     
I filed a bug report including a patch to 
https://bugs.freedesktop.org/show_bug.cgi?id=25207.

Could anyone review and commit this patch ?

Regards
 Ralf



More information about the dbus mailing list