[PATCH] get rid of --enable-verbose-mode configure option in favor of DBUS_VERBOSE env variable

Pavel Strashkin pavel.strashkin at gmail.com
Wed Jan 11 16:36:45 PST 2012


Hello everyone,

The idea behind the patch is pretty straight. Remove mix of
"verbose-mode" option and DBUS_VERBOSE env variable, and keep only the
last one to enable/disable verbose messages. Right now 48% of code
with #ifdef,
48% without and 2% with #ifdef 1. Kind of cleanup i'd say.
Another idea is ability to ask anyone provide us debug information
independently of build options in case of abnormal situation or help
developers debug their bindings (or
native implementations) against running dbus. Just set env variable
and here you go.

I re-used "_dbus_is_verbose" function so there is no performance
penalty at all (ok, may be a little bit). I also replaced some removed
#ifdef statements with the function call so heavy-duty operations will
be skipped as well.

Thank you!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: verbose_mode_is_always_enabled.patch
Type: application/octet-stream
Size: 21359 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dbus/attachments/20120111/fa50f51c/attachment-0001.obj>


More information about the dbus mailing list