<br><br><div class="gmail_quote">On Thu, Mar 10, 2011 at 8:24 AM, Vincent Torri <span dir="ltr"><<a href="mailto:vincent.torri@gmail.com">vincent.torri@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <br><br><div class="gmail_quote"><div class="im">On Thu, Mar 10, 2011 at 3:51 AM, Lennart Poettering <span dir="ltr"><<a href="mailto:mzqohf@0pointer.de" target="_blank">mzqohf@0pointer.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Heya,<br> <br> The build system in the 1.4 branch is in a really bad state.<br> <br> 2b5959882a403cddba754b37b58bdc49bff01f90 makes it impossible to build<br> anything, and even reverting that doesn't fix the messed up <a href="http://configure.ac" target="_blank">configure.ac</a><br> script, as there's brokeness such as this in the output when running configure:<br> <br> ./configure: line 16950: COMPILER_COVERAGE: command not found<br> ./configure: line 16951: COMPILER_OPTIMISATIONS: command not found<br> <br> And:<br> <br> ./configure: line 4226: : command not found<br> <br> Please let's make sure that things stay buildable at all times. If you<br> change things in <a href="http://configure.ac" target="_blank">configure.ac</a> you MUST check with "git clean -dxfq &&<br> ./autogen.sh && make -j6" whether what you are about to commit still<br> builds.<br> <br> Hmm, now, if I knew autoconf well enough to be able to fix<br> 2b5959882a403cddba754b37b58bdc49bff01f90...<br> <br> Simon?<br> <br> Thank you,<br> <br> Lennart<br></blockquote></div><div><br>btw, after having a look at <a href="http://configure.ac" target="_blank">configure.ac</a>, the use of AS_AC_EXPAND is bad. The $prefix is never known at configure time. The value of $prefix, and of all the variables that depend on $prefix (you <br> </div></div></blockquote><div><br>I finish the sentence : you break GNU rules by doing that<br> <br>Vincent Torri<br><br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="gmail_quote"><div> <br>This stuff is for example used to check if cygwin is used. Better relying on $host for that.<br><br>So, to be short, all the stuff using EXPANDED_* should be done in Makefile.am files and not in <a href="http://configure.ac" target="_blank">configure.ac</a> (except cygwin and redhat/slackware detection, that should be done in another way, maybe uname -v. Also, ask on autoconf ML for a etter solution for OS detection)<br> <br>Vincent<br></div></div> </blockquote></div><br>