some more upower fixes
martin.pitt at ubuntu.com
Thu Aug 19 04:14:17 PDT 2010
Matthias Clasen [2010-08-17 22:03 -0400]:
> We're continuing to see problems with upower and polkit 0.97, so I've
> been looking at the upower code some more. I haven't found our issue
> yet, but I noticed that some of the dbus call have the misfeature of
> returning twice (or not at all).
> I've also thrown in some memory leak fixes.
Thanks! I dissected your patch and applied it as three commits:
> diff --git a/src/up-daemon.c b/src/up-daemon.c
> index 3fb952b..4884b64 100644
> --- a/src/up-daemon.c
> +++ b/src/up-daemon.c
> @@ -477,7 +480,7 @@ up_daemon_suspend (UpDaemon *daemon, DBusGMethodInvocation *context)
> if (subject == NULL)
> goto out;
> - if (!up_polkit_check_auth (priv->polkit, subject, "org.freedesktop.upower.suspend", context))
> + if (!up_polkit_check_auth (priv->polkit, subject, "org.freedesktop.upower.suspend", NULL))
> goto out;
> /* already requested */
This is the hunk which I skipped. It looks like a regression to me
(you need the context in order to check whether the caller is
authorized), and might just be a debugging leftover?
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: Digital signature
More information about the devkit-devel