[PATCH] drm_handle_t type

Robert Noland rnoland at 2hip.net
Tue Apr 13 20:26:27 PDT 2010


On Wed, 2010-04-14 at 00:19 +0100, Matthew W. S. Bell wrote:
> On Sun, 2010-04-11 at 09:10 -0500, Robert Noland wrote:
> > On Sat, 2010-04-10 at 19:30 +0100, Matthew W. S. Bell wrote:
> > > On Mon, 2010-04-05 at 17:46 +1000, Dave Airlie wrote:
> > > > Its probably not documented well anywhere, though I think the handles are
> > > > 32-bit is written down somewhere.
> > > 
> > > Ah sorry, I missed some.
> > 
> > drm_handle_t is correct here... 
> 
> No, drm_handle_t can be of a different size to void *; converting
> between integers and pointers of different sizes causes a warning. To
> eliminate the warning, the value first needs to be passed between
> uintptr_t and void *, which are of the same size, and then converted to
> drm_handle_t. The last part is implicit; the drm_handle_t casts are
> irrelevant/useless.

No, if you look at the BSD define for drm_handle_t, it does the right
thing on each arch.  The problem is that the linux define for
drm_handle_t is u32.

robert.

> Matthew
-- 
Robert Noland <rnoland at 2hip.net>
2Hip Networks



More information about the dri-devel mailing list