[PATCH] drm/modes: Fix CVT-R modeline generation

Adam Jackson ajax at redhat.com
Mon Aug 30 07:08:05 PDT 2010


On Sat, 2010-08-28 at 22:13 +0200, Paul Menzel wrote:
> Am Montag, den 23.08.2010, 10:19 -0400 schrieb Adam Jackson:
> > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> > index f1f473e..949326d 100644
> > --- a/drivers/gpu/drm/drm_modes.c
> > +++ b/drivers/gpu/drm/drm_modes.c
> > @@ -251,7 +251,10 @@ struct drm_display_mode *drm_cvt_mode(struct drm_device *dev, int hdisplay,
> >  		drm_mode->htotal = drm_mode->hdisplay + CVT_RB_H_BLANK;
> >  		/* Fill in HSync values */
> >  		drm_mode->hsync_end = drm_mode->hdisplay + CVT_RB_H_BLANK / 2;
> > -		drm_mode->hsync_start = drm_mode->hsync_end = CVT_RB_H_SYNC;
> > +		drm_mode->hsync_start = drm_mode->hsync_end - CVT_RB_H_SYNC;
> > +		/* Fill in VSync values */
> > +		drm_mode->vsync_start = drm_mode->vdisplay + CVT_RB_VFPORCH;
> > +		drm_mode->vsync_end = drm_mode->vsync_start + vsync;
> >  	}
> >  	/* 15/13. Find pixel clock frequency (kHz for xf86) */
> >  	drm_mode->clock = drm_mode->htotal * HV_FACTOR * 1000 / hperiod;
> 
> Do you know if that was an regression in libdrm

Well it's a change to a kernel source file, so, no.

> and if that patch might
> also fix #26294 [1]? DebPkg:libdrm2 was upgraded during that time from
> 2.4.14 too.

It might.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20100830/f1a26eea/attachment.pgp>


More information about the dri-devel mailing list