[PATCH] drm/kms: remove spaces from connector names

Dave Airlie airlied at redhat.com
Wed Dec 8 16:01:01 PST 2010


On Wed, 2010-12-08 at 18:14 -0500, Alex Deucher wrote:
> Grub doesn't parse spaces in parameters correctly, so
> this makes it impossible to force video= parameters
> for kms on the grub kernel command line.

I'm sorta tempted to just go the extra step towards DIN, HDMIA, HDMIB,
DP and eDP, typing long names on the command line isn't fun.

Dave.

> 
> Reported-by: Sergej Pupykin <ml at sergej.pp.ru>
> 
> Cc: Sergej Pupykin <ml at sergej.pp.ru>
> Signed-off-by: Alex Deucher <alexdeucher at gmail.com>
> Cc: stable at kernel.org
> ---
>  drivers/gpu/drm/drm_crtc.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 6985cb1..7ee7a2f 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -156,12 +156,12 @@ static struct drm_conn_prop_enum_list drm_connector_enum_list[] =
>  	{ DRM_MODE_CONNECTOR_SVIDEO, "SVIDEO", 0 },
>  	{ DRM_MODE_CONNECTOR_LVDS, "LVDS", 0 },
>  	{ DRM_MODE_CONNECTOR_Component, "Component", 0 },
> -	{ DRM_MODE_CONNECTOR_9PinDIN, "9-pin DIN", 0 },
> +	{ DRM_MODE_CONNECTOR_9PinDIN, "9-pin_DIN", 0 },
>  	{ DRM_MODE_CONNECTOR_DisplayPort, "DisplayPort", 0 },
> -	{ DRM_MODE_CONNECTOR_HDMIA, "HDMI Type A", 0 },
> -	{ DRM_MODE_CONNECTOR_HDMIB, "HDMI Type B", 0 },
> +	{ DRM_MODE_CONNECTOR_HDMIA, "HDMI_Type_A", 0 },
> +	{ DRM_MODE_CONNECTOR_HDMIB, "HDMI_Type_B", 0 },
>  	{ DRM_MODE_CONNECTOR_TV, "TV", 0 },
> -	{ DRM_MODE_CONNECTOR_eDP, "Embedded DisplayPort", 0 },
> +	{ DRM_MODE_CONNECTOR_eDP, "Embedded_DisplayPort", 0 },
>  };
>  
>  static struct drm_prop_enum_list drm_encoder_enum_list[] =




More information about the dri-devel mailing list