[PATCH] drm/radeon/kms: only enable underscan by default if the monitor supports audio

Rafał Miłecki zajec5 at gmail.com
Fri Dec 17 08:44:02 PST 2010


2010/12/17 Alex Deucher <alexdeucher at gmail.com>:
> Users with TVs or monitors that don't overscan by default would prefer
> to not have underscan enabled, while users with overscanning TVs prefer
> underscan.  This should hopefully make everyone happy as most monitors
> with audio tend to be TVs which overscan by default and monitors without
> audio don't overscan.  Underscan can still be overriden by changing the
> connector attribute.
>
> Signed-off-by: Alex Deucher <alexdeucher at gmail.com>
> ---
>  drivers/gpu/drm/radeon/radeon_display.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index a26c1c3..3bca929 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1307,7 +1307,7 @@ bool radeon_crtc_scaling_mode_fixup(struct drm_crtc *crtc,
>                            (!(mode->flags & DRM_MODE_FLAG_INTERLACE)) &&
>                            ((radeon_encoder->underscan_type == UNDERSCAN_ON) ||
>                             ((radeon_encoder->underscan_type == UNDERSCAN_AUTO) &&
> -                             drm_detect_hdmi_monitor(radeon_connector->edid) &&
> +                             drm_detect_monitor_audio(radeon_connector->edid) &&
>                              is_hdtv_mode(mode)))) {
>                                if (radeon_encoder->underscan_hborder != 0)
>                                        radeon_crtc->h_border = radeon_encoder->underscan_hborder;

I don't like it. My TV supports audio and doesn't perform any stupid
overscanning by default. It's SONY Bravia 52''.

-- 
Rafał


More information about the dri-devel mailing list