[PATCH 4/7] cifs: use workqueue instead of slow-work

Steve French smfrench at gmail.com
Wed Jul 21 08:46:11 PDT 2010


On Tue, Jul 20, 2010 at 3:34 PM, Tejun Heo <tj at kernel.org> wrote:
> Workqueue can now handle high concurrency.  Use system_nrt_wq
> instead of slow-work.
>
> * Updated is_valid_oplock_break() to not call cifs_oplock_break_put()
>  as advised by Steve French.  It might cause deadlock.  Instead,
>  reference is increased after queueing succeeded and
>  cifs_oplock_break() briefly grabs GlobalSMBSeslock before putting
>  the cfile to make sure it doesn't put before the matching get is
>  finished.
>
> * Anton Blanchard reported that cifs conversion was using now gone
>  system_single_wq.  Use system_nrt_wq which provides non-reentrance
>  guarantee which is enough and much better.
>
> Signed-off-by: Tejun Heo <tj at kernel.org>
> Cc: Steve French <sfrench at samba.org>
> Cc: Anton Blanchard <anton at samba.org>
> ---
>  fs/cifs/Kconfig    |    1 -
>  fs/cifs/cifsfs.c   |    5 -----
>  fs/cifs/cifsglob.h |    8 +++++---
>  fs/cifs/dir.c      |    2 +-
>  fs/cifs/file.c     |   30 +++++++++++++-----------------
>  fs/cifs/misc.c     |   20 ++++++++++++--------
>  6 files changed, 31 insertions(+), 35 deletions(-)

Acked-by: Steve French <sfrench at us.ibm.com>



-- 
Thanks,

Steve


More information about the dri-devel mailing list