[PATCH] drm/radeon: Add early unregister of firmware fb's

Daniel Vetter daniel at ffwll.ch
Wed Oct 6 11:54:12 PDT 2010


On Wed, Oct 06, 2010 at 08:20:15PM +0200, Marcin Slusarz wrote:
> On Wed, Oct 06, 2010 at 06:39:07PM +0200, Daniel Vetter wrote:
> > +static void radeon_kick_out_firmware_fb(struct drm_device *ddev)
> > +{
> > +	struct apertures_struct *ap;
> > +	bool primary = false;
> > +
> > +	ap = alloc_apertures(1);
> > +	ap->ranges[0].base = pci_resource_start(ddev->pdev, 0);
> > +	ap->ranges[0].size = pci_resource_len(ddev->pdev, 0);
> 
> Any reason why this range differs from the one in radeonfb_create?
> Maybe it needs to be fixed there too?

I've stumbled over that, too. It won't really matter at all because the
fb subsystem does an intersection check. The values in radeonfb_create
look more like the correct ones, but I can't get at them before the card
is initialized.

-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48


More information about the dri-devel mailing list