[PATCH] drm/i915/lvds: Only act on lid notify when the device is on

Alex Williamson alex.williamson at redhat.com
Sun Apr 24 06:26:46 PDT 2011


On Sun, 2011-04-24 at 11:05 +0100, Chris Wilson wrote:
> On Thu, 21 Apr 2011 16:08:14 -0600, Alex Williamson <alex.williamson at redhat.com> wrote:
> > If we're using vga switcheroo, the device may be turned off
> > and poking at it can cause an oops.
> 
> I added just a couple more details to the changelog and added to my -fixes
> queue.
> 
> The question for the audience is: what is the difference between using the
> PCI power state and the drm->power_switch_state?

Seems possible we could use either.  I picked the latter because
i915_switcheroo_set_state() seems to be keeping it in sync with power
state and has the "changing" state, which might help reduce races.
Thanks,

Alex




More information about the dri-devel mailing list