[PATCH] drm/radeon/kms: fix i2c map for rv250/280

Thierry Vignaud thierry.vignaud at gmail.com
Wed Aug 3 02:21:16 PDT 2011


On 23 July 2011 20:02,  <alexdeucher at gmail.com> wrote:
> From: Alex Deucher <alexander.deucher at amd.com>
>
> Those chips have crt2_ddc bus.

Maybe adding a comment in the code'll make sure nobody will ever "clean up" or
"optimize" the tests by replacing them back by "else if (rdev->family
>= CHIP_R200)"...

> -       } else if (rdev->family >= CHIP_R200) {
> +       } else if ((rdev->family == CHIP_R200) ||
> +                  (rdev->family >= CHIP_R300)) {
>                /* 0x68 */
>                i2c = combios_setup_i2c_bus(rdev, DDC_MONID, 0, 0);
>                rdev->i2c_bus[3] = radeon_i2c_create(dev, &i2c, "MONID");

My 2 cents


More information about the dri-devel mailing list