high_memory address in /proc/dri/*/vma
ben at decadent.org.uk
Sun Dec 18 17:23:04 PST 2011
Kees, in commit 01e2f533a234dc62d16c0d3d4fb9d71cf1ce50c3 ("drm: do not
leak kernel addresses via /proc/dri/*/vma") you changed the logging of
- seq_printf(m, "vma use count: %d, high_memory = %p, 0x%08llx\n",
+ seq_printf(m, "vma use count: %d, high_memory = %pK, 0x%pK\n",
- high_memory, (u64)virt_to_phys(high_memory));
+ high_memory, (void *)virt_to_phys(high_memory));
This doesn't make sense because the physical address may be truncated
(in theory at least).
I think it would make more sense to make this entire file readable by
root only, but I don't know whether anything depends on being able to
read it. Its existence is conditional on DRM_DEBUG_CODE != 0 but that
is always true at the moment.
Humans are not rational beings; they are rationalising beings.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 828 bytes
Desc: This is a digitally signed message part
More information about the dri-devel