[PATCH v3] pci: use security_capable() when checking capablities during config space read
raa.lkml at gmail.com
Tue Feb 15 22:24:34 PST 2011
On Tue, Feb 15, 2011 at 02:21, Chris Wright <chrisw at sous-sol.org> wrote:
> This reintroduces commit 47970b1b which was subsequently reverted
> as f00eaeea. The original change was broken and caused X startup
> failures and generally made privileged processes incapable of reading
> device dependent config space. The normal capable() interface returns
> true on success, but the LSM interface returns 0 on success. This thinko
> is now fixed in this patch, and has been confirmed to work properly.
> So, once again...Eric Paris noted that commit de139a3 ("pci: check caps
> from sysfs file open to read device dependent config space") caused the
> capability check to bypass security modules and potentially auditing.
> Rectify this by calling security_capable() when checking the open file's
> capabilities for config space reads.
> Reported-by: Eric Paris <eparis at redhat.com>
> Tested-by: Dave Young <hidave.darkstar at gmail.com>
> Acked-by: James Morris <jmorris at namei.org>
> Cc: Dave Airlie <airlied at gmail.com>
> Cc: Alex Riesen <raa.lkml at gmail.com>
> Cc: Sedat Dilek <sedat.dilek at googlemail.com>
> Cc: Linus Torvalds <torvalds at linux-foundation.org>
> Signed-off-by: Chris Wright <chrisw at sous-sol.org>
FWIW, I confirm the fix.
More information about the dri-devel