[PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format

Jesse Barnes jbarnes at virtuousgeek.org
Fri Nov 4 07:13:26 PDT 2011


On Fri, 04 Nov 2011 16:34:22 +0900
Joonyoung Shim <jy0922.shim at samsung.com> wrote:

> > +	case V4L2_PIX_FMT_RGB24:
> > +		*depth = 24;
> > +		*bpp = 24;
> > +		break;  
> 
> In the depth = 24 and bpp = 32 case also the pixed_format is
> V4L2_PIX_FMT_RGB24, but above function cannot detect it.

Oh that's a mistake on my part.  RGB24 is generally bpp=32.  I'll fix
that.

This is just a compatibility function, so it only needs to handle cases
used by current code.  I expect future code to use the fourcc values
directly.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20111104/5b43a005/attachment.pgp>


More information about the dri-devel mailing list