[PATCH 1/7] drm: Zero initialize drm_mode_fb_cmd2 in legacy addfb ioctl handler

Jesse Barnes jbarnes at virtuousgeek.org
Fri Nov 11 08:55:42 PST 2011


On Fri, 11 Nov 2011 18:04:01 +0200
ville.syrjala at linux.intel.com wrote:

> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Avoids having junk in offsets[] and pitches[] arrays.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/drm_crtc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 39cccb4..7058ed3 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -1967,7 +1967,7 @@ int drm_mode_addfb(struct drm_device *dev,
>  		   void *data, struct drm_file *file_priv)
>  {
>  	struct drm_mode_fb_cmd *or = data;
> -	struct drm_mode_fb_cmd2 r;
> +	struct drm_mode_fb_cmd2 r = {};
>  	struct drm_mode_config *config = &dev->mode_config;
>  	struct drm_framebuffer *fb;
>  	int ret = 0;

Yep, doesn't hurt...

Acked-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20111111/3042c597/attachment-0001.pgp>


More information about the dri-devel mailing list