[PATCH 1/2] drm/radeon/kms: Hide debugging message

Jean Delvare jdelvare at suse.de
Wed Nov 30 08:26:36 PST 2011


Use the proper macro to issue the debugging message in
radeon_atif_call(). Otherwise we spam the log of many systems with a
message which looks like an error message of unknown origin, and could
thus confuse the user. Commit dc77de12dde95c8da39e4c417eb70c7d445cf84b
was a first step in this direction, but was not sufficient IMHO.

Signed-off-by: Jean Delvare <jdelvare at suse.de>
Cc: David Airlie <airlied at linux.ie>
Cc: Alex Deucher <alexander.deucher at amd.com>
---
Might be considered for stable, this is not a critical bug but it can
waste time of users and developers alike.

 drivers/gpu/drm/radeon/radeon_acpi.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-3.2-rc3.orig/drivers/gpu/drm/radeon/radeon_acpi.c	2011-11-29 17:47:02.000000000 +0100
+++ linux-3.2-rc3/drivers/gpu/drm/radeon/radeon_acpi.c	2011-11-29 18:12:02.000000000 +0100
@@ -35,7 +35,8 @@ static int radeon_atif_call(acpi_handle
 
 	/* Fail only if calling the method fails and ATIF is supported */
 	if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) {
-		printk(KERN_DEBUG "failed to evaluate ATIF got %s\n", acpi_format_exception(status));
+		DRM_DEBUG_DRIVER("failed to evaluate ATIF got %s\n",
+				 acpi_format_exception(status));
 		kfree(buffer.pointer);
 		return 1;
 	}

-- 
Jean Delvare
Suse L3


More information about the dri-devel mailing list