[PATCH 06/13] drm/radeon: improve sub allocator

Christian König deathsimple at vodafone.de
Fri Apr 20 02:11:53 PDT 2012


On 20.04.2012 09:24, Michel Dänzer wrote:
> On Fre, 2012-04-20 at 00:39 +0200, Christian König wrote:
>> Make the suballocator self containing to locking
>> and fix a overrun bug which happens with
>> allocations of different alignments.
> Sounds like this should be split up into two changes. :)

Yeah you are probably right.

But wait a moment, thinking about it some more the overrun bug is 
actually a quite critical bug in mainline, cause it quickly leads to 
memory corruption if two users of the SA have different alignment 
restrictions. And hell, there currently is at least the IB pool (256 
bytes) and the VM code (4096 bytes alignment) using it, so this could be 
responsible for some of the VM corruptions we are seeing!!!

Going to write a patch immediately,
Christian.


More information about the dri-devel mailing list