[RFC v2 2/5] tps6586x: Add device tree support
thierry.reding at avionic-design.de
Wed Apr 25 03:41:47 PDT 2012
* Thierry Reding wrote:
> * Mark Brown wrote:
> > On Wed, Apr 25, 2012 at 11:44:59AM +0200, Thierry Reding wrote:
> > > This commit adds device tree support for the TPS6586x regulator.
> > >
> > > Signed-off-by: Thierry Reding <thierry.reding at avionic-design.de>
> > This looks basically good from a quick scan through but the pattern of
> > looking up regulator nodes by name is very common so should be factored
> > out - I made a similar comment in response to a recent patch from
> > Rhyland Klein and earlier today he posted a patch "regulator: add
> > generic of node parsing for regulators" which does just that. Can you
> > please redo this on top of his code? I'll probably apply it later
> > today, though I didn't properly read the code yet.
> I'll take a look.
After taking a closer look I don't think Rhyland's patch is very useful for
this driver. I need to lookup the platform ID by regulator name anyway so
using the new code is actually more work and requires a second table that
lists the regulator names only.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the dri-devel