[PATCH] drm: cleanup device registration

David Airlie airlied at redhat.com
Thu Feb 2 04:40:17 PST 2012



----- Original Message -----
> From: "Sascha Hauer" <s.hauer at pengutronix.de>
> To: "David Airlie" <airlied at redhat.com>
> Cc: "Inki Dae" <inki.dae at samsung.com>, kernel at pengutronix.de, dri-devel at lists.freedesktop.org
> Sent: Thursday, 2 February, 2012 12:34:02 PM
> Subject: Re: [PATCH] drm: cleanup device registration
> 
> On Thu, Feb 02, 2012 at 07:05:00AM -0500, David Airlie wrote:
> > ----- Original Message -----
> > > From: "Sascha Hauer" <s.hauer at pengutronix.de>
> > > To: dri-devel at lists.freedesktop.org
> > > Cc: "Inki Dae" <inki.dae at samsung.com>, kernel at pengutronix.de
> > > Sent: Thursday, 2 February, 2012 11:57:52 AM
> > > Subject: [PATCH] drm: cleanup device registration
> > > 
> > > The non modesetting drm drivers currently use a handcrafted pci
> > > probe
> > > function. This requires the drm core to keep a list of registered
> > > devices
> > > for each driver. This series adds a probe function for the non
> > > modesetting
> > > drivers and removes the legacy probe code. The USB and platform
> > > drivers
> > > use the devices_list aswell which is unnecessary. This is also
> > > cleaned
> > > up in this series.
> > 
> > No it can't work like this because we have conflicts between fb and
> > drm drivers, so the DRM is required to do its own
> > probe if an fb driver for a device is already loaded.
> > 
> > it can't use the PCI probe out of the box.
> 
> I see. For example the i810 also has a framebuffer driver. Do you see
> a way to fix this except writing a kms driver for all legacy devices?
> Otherwise I would leave the pci part untouched and only keep the
> platform/USB pieces which I'm admittedly more interested in.
> 

Its one of those things that would be a real pain to fix, since we can't remove
drm drivers since their interfaces are ABI. So its why its been left like it is.

It might be possible to split the PCI path up a bit so the non-kms drivers use it,
and we port kms ones to a newer interfaces, but I think nouveau is the only PCI KMS only
driver we have (maybe vmwgfx as well).

Dave.


More information about the dri-devel mailing list