[PATCH] intel, gma500, lvds: Fix use after free on psb_intel_lvds_init()
jj at chaosbits.net
Sat Jan 14 12:58:49 PST 2012
On Sat, 14 Jan 2012, Jesper Juhl wrote:
> In psb_intel_lvds_init(), if we fail to allocate memory for
> 'psb_intel_connector' we free the memory we previously allocated for
> 'psb_intel_encoder', but we then proceed to use that free'd pointer
> when we do 'psb_intel_encoder->dev_priv = lvds_priv;'.
> I believe the proper way to handle this is to simply return after the
> allocation for 'psb_intel_connector' has failed. That is what this
> patch does.
Ok, so I just noticed that we may also leak 'psb_intel_encoder' if we
'goto failed_connector;'. Might as well fix that as well in the same
So please just ignore this one. I'll submit a new one in a little
while that handles both leaks.
Jesper Juhl <jj at chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
More information about the dri-devel