[RFC PATCH] vmwgfx: Fix assignment in vmw_framebuffer_create_handle
thellstrom at vmware.com
Fri Jan 27 06:09:51 PST 2012
Thanks for pointing this out. Unfortunately there seems to be two bugs
here, the one you pointed out and the fact that we set the handle to zero,
when it probably should be set to struct vmw_framebuffer::user_handle.
Jakob, can you comment on this?
On 01/27/2012 07:25 AM, Ryan Mallon wrote:
> The assignment of handle in vmw_framebuffer_create_handle doesn't
> actually do anything useful and is incorrectly assigning an integer
> value to a pointer argument. It appears that this is a typo and should
> be dereferencing handle rather than assigning to it directly.
> Signed-off-by: Ryan Mallon<rmallon at gmail.com>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> index 0af6ebd..b66ef0e 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -378,7 +378,7 @@ int vmw_framebuffer_create_handle(struct drm_framebuffer *fb,
> unsigned int *handle)
> if (handle)
> - handle = 0;
> + *handle = 0;
> return 0;
More information about the dri-devel