[PATCH] drm/radeon: Mark all possible functions / structs as static

[Lauri Kasanen]

On Tue, 31 Jul 2012 14:43:34 +1000
Dave Airlie <airlied at gmail.com> wrote:

> On Tue, Jul 31, 2012 at 12:45 AM, Alex Deucher <alexdeucher at gmail.com> wrote:
> > On Fri, Jul 27, 2012 at 5:34 PM, Lauri Kasanen <cand at gmx.com> wrote:
> >> Let's allow GCC to optimize better.
> >>
> >> This exposed some five unused functions, but this patch doesn't remove them.
> >>
> >> Signed-off-by: Lauri Kasanen <cand at gmx.com>
> >
> > Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> 
> You might want to take this one step further and fix all the warnings
> it introduces here,
> 
>   CC [M]  drivers/gpu/drm/radeon/radeon_combios.o
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/radeon/radeon_combios.c:3307:13:
> warning: ‘radeon_combios_dyn_clk_setup’ defined but not used
> [-Wunused-function]
>  CC [M]  drivers/gpu/drm/radeon/radeon_legacy_crtc.o
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/radeon/radeon_legacy_crtc.c:209:13:
> warning: ‘radeon_restore_common_regs’ defined but not used
> [-Wunused-function]
> 
>   CC [M]  drivers/gpu/drm/radeon/r100.o
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/radeon/r100.c:2548:13:
> warning: ‘r100_gpu_wait_for_vsync’ defined but not used
> [-Wunused-function]
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/radeon/r100.c:2570:13:
> warning: ‘r100_gpu_wait_for_vsync2’ defined but not used
> [-Wunused-function]
> 
> Not sure we want to lose all these functions or just if 0 them out for
> reference purposes, or even why we might need to call some of them.

That's why I didn't remove them. I don't have the info on whether they are needed or not, someone qualified will need to make that decision.

- Lauri