[PATCH 10/13 v4] drm/i915/intel_i2c: always wait for IDLE before clearing NAK
chris at chris-wilson.co.uk
Tue Mar 27 12:17:59 PDT 2012
On Wed, 28 Mar 2012 02:36:19 +0800, Daniel Kurtz <djkurtz at chromium.org> wrote:
> The GMBUS controller can report a NAK condition while a transaction is
> still active. If the driver is fast enough, and the bus is slow enough,
> the driver may clear the NAK condition while the controller is still
> busy, resulting in a confused GMBUS controller. This will leave the
> controller in a bad state such that the next transaction may fail.
> Also, return -ENXIO if a device NAKs a transaction.
> Note: this patch also refactors gmbus_xfer to remove the "done" label.
> Signed-off-by: Daniel Kurtz <djkurtz at chromium.org>
Thanks for clarifying the appropriate return codes.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Chris Wilson, Intel Open Source Technology Centre
More information about the dri-devel