[PATCH 2/8] drm: WARN() when drm_connector_attach_property fails

Chris Wilson chris at chris-wilson.co.uk
Thu Mar 29 14:49:55 PDT 2012


On Thu, 29 Mar 2012 18:27:20 -0300, Paulo Zanoni <przanoni at gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> Also return void instead of int. We have more than 100 callers and
> no one checks for the return value.
> 
> If this function fails the property won't be exposed by the get/set
> ioctls, but we should probably survive. If this starts happening,
> the solution will be to increase DRM_CONNECTOR_MAX_PROPERTY and
> recompile the Kernel.

Please add that to the error message and use printk_once() since we only
really want to annoy the user the first time.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list