[Intel-gfx] [PATCH 2/4] drm/i915: clarify preferred sdvo input mode code

Daniel Vetter daniel at ffwll.ch
Tue May 22 00:33:08 PDT 2012


On Tue, Apr 10, 2012 at 01:18:13PM +0100, Chris Wilson wrote:
> On Tue, 10 Apr 2012 13:55:47 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > - kill intel_sdvo->input_dtd, it's only used as a temporary variable,
> >   we store the preferred input mode in the adjusted mode at mode_fixup
> >   time.
> > - rename the function to make it clear what we want it to do (get the
> >   preferred mode) and say in a comment what it unfortunately does as a
> >   side-effect (set the new output timings).
> > 
> > Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> Patches 2-4: Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
I've queued patches 2&3 for -next, thanks for the review. I'll propably
redo patch 4 with the new constants once the interlaced fixup is merged
back into -next.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48


More information about the dri-devel mailing list