[PATCH] drm/exynos: Make g2d_pm_ops static

InKi Dae inki.dae at samsung.com
Sun Sep 2 19:39:36 PDT 2012


Applied. Thanks.

2012/8/29 Sachin Kamat <sachin.kamat at linaro.org>:
> On 29 August 2012 12:32, Joonyoung Shim <jy0922.shim at samsung.com> wrote:
>> On 08/28/2012 05:41 PM, Sachin Kamat wrote:
>>>
>>> Fixes the following warning:
>>> drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning:
>>> symbol 'g2d_pm_ops' was not declared. Should it be static?
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
>>> ---
>>>   drivers/gpu/drm/exynos/exynos_drm_g2d.c |    2 +-
>>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>>> b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>>> index 6adfa4e..1065e90 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>>> @@ -894,7 +894,7 @@ static int g2d_resume(struct device *dev)
>>>   }
>>>   #endif
>>>   -SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume);
>>> +static SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume);
>>
>>
>> Right, it should be static but i don't get any warning message without
>> static.
>
> You will get it if you enable sparse checking while building the kernel.
>
>>
>> Thanks.
>>
>>
>>>     struct platform_driver g2d_driver = {
>>>         .probe          = g2d_probe,
>>
>>
>
>
>
> --
> With warm regards,
> Sachin
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list