[PATCH 2/3] drm/radeon: clean up audio dto programming

Rafał Miłecki zajec5 at gmail.com
Thu Apr 18 23:10:47 PDT 2013


2013/4/18  <alexdeucher at gmail.com>:
> -       switch (radeon_encoder->encoder_id) {
> -       case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_TMDS1:
> -       case ENCODER_OBJECT_ID_INTERNAL_LVTM1:
> -               WREG32_P(R600_AUDIO_TIMING, 0, ~0x301);
> -               break;
> -       case ENCODER_OBJECT_ID_INTERNAL_UNIPHY:
> -       case ENCODER_OBJECT_ID_INTERNAL_UNIPHY1:
> -       case ENCODER_OBJECT_ID_INTERNAL_UNIPHY2:
> -       case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_LVTMA:
> -               WREG32_P(R600_AUDIO_TIMING, 0x100, ~0x301);
> -               break;
> -       default:
> -               dev_err(rdev->dev, "Unsupported encoder type 0x%02X\n",
> -                         radeon_encoder->encoder_id);
> -               return;
> -       }

Are you sure we can just drop that part?

I'd appreciate waiting with this patch until next week, I'll test it
over the weekend on my RV620.

-- 
Rafał


More information about the dri-devel mailing list