[PATCH] drm: Fix undefined reference to drm_agp_clear() on non-AGP platforms

Daniel Vetter daniel at ffwll.ch
Wed Aug 7 05:19:34 PDT 2013


On Wed, Aug 7, 2013 at 2:17 PM, Laurent Pinchart
<laurent.pinchart+renesas at ideasonboard.com> wrote:
> The drm_agp_clear() function is only defined on platforms with AGP
> support. Move the drm_core_has_AGP() check from drm_agp_clear() to the
> caller to let the compiler optimize the drm_agp_clear() call away.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>

Can't we use the usual approach of an empty static inline helper for
the !CONFIG_AGP case here?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list