[PATCH 22/25] drm: no-op out GET_STATS ioctl

Eric Anholt eric at anholt.net
Thu Aug 8 08:55:45 PDT 2013


Daniel Vetter <daniel.vetter at ffwll.ch> writes:

> Again only used by a tests in libdrm and by dristat. Nowadays we have
> much better tracing tools to get detailed insights into what a drm
> driver is doing. And for a simple "does it work" kind of question that
> these stats could answer we have plenty of dmesg debug log spew.
>
> So I don't see any use for this stat gathering complexity at all.
>
> To be able to gradually drop things start with ripping out the
> interfaces to it, here the ioctl.
>
> To prevent dristat from eating its own stack garbage we can't use the
> drm_noop ioctl though, since we need to clear the return data with a
> memset.

I'm happy to see these two die.  Even back in the day we didn't use
them.

This has been quite a trip down memory lane.

Patch 9 typo: s/functinal/functional/
Patch 25 typo: s/loose/lose/

Patches 2, 6-11, 19, 21, 22, 24, 25 are:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20130808/5d231387/attachment.pgp>


More information about the dri-devel mailing list