[PATCH] Mark drmServerInfo.debug_print with printf attribute

Keith Packard keithp at keithp.com
Wed Dec 11 22:42:00 PST 2013


Alan Coopersmith <alan.coopersmith at oracle.com> writes:

> You should drop that line - those comments are used for us to figure out which
> xproto version to list in the pkg-config requirements when using newer _X_* 
> macros out of Xfuncproto.h, so doesn't make sense here.
>
> Also be warned that using a macro name starting with an _ will cause you to get
> complaints about violating the "reserved for the implementation" rule in the
> ANSI/ISO C standards from people who consider the implementation to solely be
> the compiler, not the OS.  https://bugs.freedesktop.org/show_bug.cgi?id=70686
> for example.

Thanks for the suggestions; both easy to adopt.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20131211/1c00a250/attachment.pgp>


More information about the dri-devel mailing list