[PATCH 7/8] drm/tiledc: Remove redundant debugfs cleanup

Rob Clark robdclark at gmail.com
Sun Jul 7 16:40:16 PDT 2013


On Sun, Jul 7, 2013 at 3:02 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> All inode removal is handled for us by the core.

Acked-by: Rob Clark <robdclark at gmail.com>

> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Darren Etheridge <detheridge at ti.com>
> Cc: Benoit Parrot <bparrot at ti.com>
> Cc: Rob Clark <robdclark at gmail.com>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 12 ------------
>  drivers/gpu/drm/tilcdc/tilcdc_drv.h |  2 --
>  2 files changed, 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 40b71da..c481843 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -474,17 +474,6 @@ static int tilcdc_debugfs_init(struct drm_minor *minor)
>
>         return ret;
>  }
> -
> -static void tilcdc_debugfs_cleanup(struct drm_minor *minor)
> -{
> -       struct tilcdc_module *mod;
> -       drm_debugfs_remove_files(tilcdc_debugfs_list,
> -                       ARRAY_SIZE(tilcdc_debugfs_list), minor);
> -
> -       list_for_each_entry(mod, &module_list, list)
> -               if (mod->funcs->debugfs_cleanup)
> -                       mod->funcs->debugfs_cleanup(mod, minor);
> -}
>  #endif
>
>  static const struct file_operations fops = {
> @@ -522,7 +511,6 @@ static struct drm_driver tilcdc_driver = {
>         .dumb_destroy       = drm_gem_cma_dumb_destroy,
>  #ifdef CONFIG_DEBUG_FS
>         .debugfs_init       = tilcdc_debugfs_init,
> -       .debugfs_cleanup    = tilcdc_debugfs_cleanup,
>  #endif
>         .fops               = &fops,
>         .name               = "tilcdc",
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/tilcdc_drv.h
> index 0938036..56fe122 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h
> @@ -102,8 +102,6 @@ struct tilcdc_module_ops {
>  #ifdef CONFIG_DEBUG_FS
>         /* create debugfs nodes (can be NULL): */
>         int (*debugfs_init)(struct tilcdc_module *mod, struct drm_minor *minor);
> -       /* cleanup debugfs nodes (can be NULL): */
> -       void (*debugfs_cleanup)(struct tilcdc_module *mod, struct drm_minor *minor);
>  #endif
>  };
>
> --
> 1.8.3.2
>


More information about the dri-devel mailing list