[PATCH] drm/prime: remove cargo-cult locking from map_sg helper

[Daniel Vetter]

On Wed, Jul 10, 2013 at 3:46 PM, Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
> On Wednesday 10 July 2013 13:54:33 Daniel Vetter wrote:
>> I've checked both implementations (radeon/nouveau) and they both grab
>> the page array from ttm simply by dereferencing it and then wrapping
>> it up with drm_prime_pages_to_sg in the callback and map it with
>> dma_map_sg (in the helper).
>
> Have you checked drm_gem_cma_prime_get_sg_table (in drm_gem_cma_helper.c) as
> well ?

Indeed I've missed to check this one since I've based this branch
originally on an older drm-next version without the cma dma-buf stuff.
drm_gem_cma_prime_get_sg_table only calls kzalloc and the creates&maps
the sg table with dma_get_sgtable. It doesn't touch any gem object
state otherwise.

So looks safe. I'll amed the commit message a bit.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch