Bug in warning message from MTRR rework in uvesafb

Andy Lutomirski luto at amacapital.net
Wed Jul 10 10:36:22 PDT 2013


On Wed, Jul 10, 2013 at 10:07 AM, Torsten Kaiser
<just.for.lkml at googlemail.com> wrote:
> Commit 63e28a7a5ffce59b645ca9cbcc01e1e8be56bd75, "uvesafb: Clean up
> MTRR code" contains the following change:
>
> @@ -1930,6 +1891,9 @@ static int uvesafb_setup(char *options)
>          }
>      }
>
> +    if (mtrr != 3 && mtrr != 1)
> +        pr_warn("uvesafb: mtrr should be set to 0 or 3; %d is
> unsupported", mtrr);
> +
>      return 0;
>  }
>  #endif /* !MODULE */
>
> Shouldn't this be && mtrr != 0?

Indeed, and Sylvain Hitier (cc'd) sent a patch (off-list) that must
have gotten lost somewhere.

--Andy


More information about the dri-devel mailing list