build warning on 32-bit

Chris Wilson chris at chris-wilson.co.uk
Tue Jun 11 00:39:16 PDT 2013


On Tue, Jun 11, 2013 at 10:03:06AM +0300, Ville Syrjälä wrote:
> On Tue, Jun 11, 2013 at 08:55:03AM +1000, Dave Airlie wrote:
> >   CC [M]  drivers/gpu/drm/i915/i915_gem.o
> > /ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c: In function
> > ‘i915_gem_object_bind_to_gtt’:
> > /ssd/git/drm-next/drivers/gpu/drm/i915/i915_gem.c:3000:3: warning:
> > format ‘%ld’ expects argument of type ‘long int’, but argument 5 has
> > type ‘size_t’ [-Wformat]
> >   CC [M]  drivers/gpu/drm/i915/i915_gem_context.o
> 
> I think Jani had a fix for this one:
> https://patchwork.kernel.org/patch/2686801/

It is fixing the wrong thing, imo. The issue is that we have a random mix
of types that we need to sort out. (Here is a prime example, the
conditional switching between gtt.total and gtt.mappable_end, both
describing limits in the GTT have size_t and unsigned long respectively.)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list