RADEON / DPM: GPU cannot properly up-clock

[Deucher, Alexander]

> -----Original Message-----
> From: Joshua C. [mailto:joshuacov at gmail.com]
> Sent: Wednesday, June 26, 2013 1:52 PM
> To: dri-devel at lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: RADEON / DPM: GPU cannot properly up-clock
> 
> First of all thank you guys for pushing this out! Great work!
> 
> I tried the latest code in drm-next-3.11-wip (up to commit
> b3c1e0c3ba885db44 "drm/radeon: fix endian issues in atombios dpm
> code") in connection with the latest radeon_ucode (latest update on
> 2013-06-26). I also reintroduced the debugfs info so that I can better
> observe the gpu-settings. For this I put back the following patch:
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_pm.c
> b/drivers/gpu/drm/radeon/radeon_pm.c
> index 7ba5d6f..9367234 100644
> --- a/drivers/gpu/drm/radeon/radeon_pm.c
> +++ b/drivers/gpu/drm/radeon/radeon_pm.c
> @@ -1066,6 +1066,11 @@ static int radeon_pm_init_dpm(struct
> radeon_device *rdev)
>          ret = device_create_file(rdev->dev, &dev_attr_power_method);
>          if (ret)
>              DRM_ERROR("failed to create device file for power method\n");
> +
> +        if (radeon_debugfs_pm_init(rdev)) {
> +            DRM_ERROR("Failed to register debugfs file for PM!\n");
> +        }
> +
>          DRM_INFO("radeon: dpm initialized\n");
>      }
> 
> --
> 1.8.2.1

I removed that code for a reason when DPM is active.  With DPM the hardware changes the power state dynamically internally so that old debugging information is completely irrelevant when DPM is active.

Alex