Enhance EDID quirks to allow forcing a mode

Daniel Vetter daniel at ffwll.ch
Fri Mar 22 01:48:44 PDT 2013


On Thu, Mar 21, 2013 at 10:42 PM, Dylan Semler <dylan.semler at gmail.com> wrote:
> Oops.  I neglected to preface this with my motivation:  I have a new monitor
> that doesn't report its native resolution in its EDID block.  It seemed to
> me
> this calls for an EDID quirk, but the current quirk infrastructure doesn't
> allow explicitly creating new modes.  So I set out to make a simple
> enhancement
> to allow specifying a new mode and then setting it as preferred.
>
>
>
> On Thu, Mar 21, 2013 at 5:36 PM, Dylan Semler <dylan.semler at gmail.com>
> wrote:
>>
>> The idea is setup a new quirk list with width, height, and refresh rates
>> for
>> each monitor that needs this quirk.  If a monitor is attached that matches
>> one
>> in this list, the full modeline is calculated with drm_gtf_mode, the
>> DRM_MODE_TYPE_PREFERRED bit is set, and the new mode is added to the
>> connector.
>>
>> The patch also creates a new quirk bit:  EDID_QUIRK_FORCE_MODE.  This bit
>> needs
>> to be set for the new quirk list discribed above to be checked.
>>
>> The first patch enhances the quirk logic as described above.  The second
>> one
>> adds my new monitor to the quirk lists.

I think it'd be good to shovel these text blocks into the (currently
rather empty) commit messages of the patches. Since when reading old
commits with e.g. git blame that's what people will read.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list