[PATCH] drm: Pad drm_mode_get_connector to 64-bit boundary

Jani Nikula jani.nikula at linux.intel.com
Wed Oct 16 12:54:37 CEST 2013


On Wed, 16 Oct 2013, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Wed, Oct 16, 2013 at 01:14:53PM +0300, Jani Nikula wrote:
>> > --- a/include/uapi/drm/drm_mode.h
>> > +++ b/include/uapi/drm/drm_mode.h
>> > @@ -223,6 +223,8 @@ struct drm_mode_get_connector {
>> >  	__u32 connection;
>> >  	__u32 mm_width, mm_height; /**< HxW in millimeters */
>> >  	__u32 subpixel;
>> > +
>> > +	__u32 pad;
>> 
>> Would a small comment here be in order?
>
> We haven't explained padding in the past. It has been taken for granted
> that the pad members are there to make compat problems disappear.

Okay, sorry for the noise.

J.

-- 
Jani Nikula, Intel Open Source Technology Center


More information about the dri-devel mailing list