[PATCH] drm/mm: Don't WARN if drm_mm_reserve_node

Daniel Vetter daniel.vetter at ffwll.ch
Mon Apr 7 14:25:20 PDT 2014


Jesse's BIOS fb reconstruction code actually relies on the -ENOSPC
return value to detect overlapping framebuffers (which the bios uses
always when lighting up more than one screen). All this fanciness
happens in intel_alloc_plane_obj in intel_display.c.

Since no one else uses this we can savely remove the WARN without
repercursions.

Reported-by: Ben Widawsky <benjamin.widawsky at intel.com>
Cc: Ben Widawsky <benjamin.widawsky at intel.com>
Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
Cc: Dave Airlie <airlied at redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
---
 drivers/gpu/drm/drm_mm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index a2d45b748f86..e4dfd5c3b15e 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -192,8 +192,6 @@ int drm_mm_reserve_node(struct drm_mm *mm, struct drm_mm_node *node)
 		return 0;
 	}
 
-	WARN(1, "no hole found for node 0x%lx + 0x%lx\n",
-	     node->start, node->size);
 	return -ENOSPC;
 }
 EXPORT_SYMBOL(drm_mm_reserve_node);
-- 
1.8.5.2



More information about the dri-devel mailing list