[PATCH 1/3] ARM: tegra: Deprecate nvidia,hpd-gpio property

Stephen Warren swarren at wwwdotorg.org
Mon Apr 21 12:43:18 PDT 2014


On 04/17/2014 06:02 AM, Thierry Reding wrote:
> From: Thierry Reding <treding at nvidia.com>
> 
> Properties referencing GPIOs should use the plural suffix -gpios. This
> convention is encoded in the device tree backend of gpiod_get(), which
> we'll eventually want to migrate to.

Wouldn't it be simpler to fix the GPIO binding documentation and
gpiod_get() code to allow the -gpio suffix in addition to -gpios? It
always struck me as silly that the binding required a plural property
name when only a single entry made sense.

(For something like "clocks", since the property name applies to any
clock, and there certainly can be many clocks, a plural property name
makes sense. However, since each type of GPIO is "foo-gpios" rather than
an "foo" entry in "gpios", that same argument doesn't apply, and a
singular property name seems much more correct).


More information about the dri-devel mailing list