[PATCH] drm: Simplify fb refcounting rules around ->update_plane

Daniel Vetter daniel.vetter at ffwll.ch
Tue Apr 22 23:41:41 PDT 2014


On Wed, Apr 23, 2014 at 8:36 AM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Hm, that's indeed a bit fishy. Otoh I don't understand how this blows
> up with existing userspace since we should only hit this if userspace
> does an explicit disable call on the primary plane through the ioctl.
> It's a bug for sure though.

Actually even before

commit b6ccd7b9873dc46becd11838c885d5c783784156
Author: Daniel Vetter <daniel.vetter at ffwll.ch>
Date:   Tue Apr 15 10:02:43 2014 +0200

    drm/plane-helper: Don't fake-implement primary plane disabling

this was broken since if any other plane was enabled it would return
-EBUSY. So this might actually explain the refcounting woes since the
above patch isn't yet merged into any of the upstream drm trees.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list