[PATCH] staging: drm/imx: remove an unnecessary local variable

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Feb 10 02:45:04 PST 2014


On Mon, Feb 10, 2014 at 06:42:57PM +0800, Liu Ying wrote:
> On 02/10/2014 06:29 PM, Russell King - ARM Linux wrote:
> > On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote:
> >> This patch removes an unnecessary local variable defined
> >> in the function imx_drm_driver_unload() so as to fix the
> >> following build warning.
> >>
> >> drivers/staging/imx-drm/imx-drm-core.c: \
> >> In function ‘imx_drm_driver_unload’:
> >> drivers/staging/imx-drm/imx-drm-core.c:87:25: \
> >> warning: unused variable ‘imxdrm’ [-Wunused-variable]
> > 
> > Already-Naked-by: me.  This is required by later patches in the series
> > posted earlier.
> > 
> 
> Sorry. Did you mean that you have already got a fix for this?

No, I mean patches which come after the three which Greg has recently
merged - one of which removes users of the above variable - reintroduce
users of this variable, so deleting the variable will break those patches.
It was also pointless to remove it and then bring it back in the series.

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".


More information about the dri-devel mailing list