[PATCH 1/1] drm/tilcdc: Fix build breakage

Daniel Vetter daniel at ffwll.ch
Thu Jul 10 00:09:15 PDT 2014


On Thu, Jul 10, 2014 at 12:02:15PM +1000, Dave Airlie wrote:
> On 9 July 2014 21:42, Sachin Kamat <sachin.kamat at samsung.com> wrote:
> > Commit 34ea3d386347 ("drm: add register and unregister functions
> > for connectors") probably missed out converting the
> > drm_sysfs_connector_remove instances in the following files.
> > Without this patch we get the following compilation error:
> > ERROR: "drm_sysfs_connector_remove" [drivers/gpu/drm/tilcdc/tilcdc.ko] undefined!
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat at samsung.com>
> > CC: Thomas Wood <thomas.wood at intel.com>
> > CC: David Herrmann <dh.herrmann at gmail.com>
> > CC: Daniel Vetter <daniel.vetter at ffwll.ch>
> > ---
> > Only compile tested.
> 
> Oops, applied thanks,
> 
> I did an arm build just on the drm dir, forgot to let it run to
> completion over the whole tree.

Yeah, my apologies for breaking things. Nowadays I rely on the 0-day
builder for arm build testing, dunno why it didn't report this one here.
Might be good to check with Wu Fengguang that your driver is included - he
tends to catch other drm breakage on arm drivers well.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list