[PATCH] drm/dp: Staticize a couple of DP utility functions

[Alex Deucher]

On Mon, Jul 21, 2014 at 7:23 AM, Thierry Reding
<thierry.reding at gmail.com> wrote:
> From: Thierry Reding <treding at nvidia.com>
>
> sparse complains about these functions missing a prototype, but looking
> closer they aren't (and likely not supposed to be) used outside of this
> source file, so they can be made static.
>
> Signed-off-by: Thierry Reding <treding at nvidia.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 369d6c49145b..c9a772554308 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -1482,10 +1482,10 @@ static int drm_dp_send_enum_path_resources(struct drm_dp_mst_topology_mgr *mgr,
>         return 0;
>  }
>
> -int drm_dp_payload_send_msg(struct drm_dp_mst_topology_mgr *mgr,
> -                           struct drm_dp_mst_port *port,
> -                           int id,
> -                           int pbn)
> +static int drm_dp_payload_send_msg(struct drm_dp_mst_topology_mgr *mgr,
> +                                  struct drm_dp_mst_port *port,
> +                                  int id,
> +                                  int pbn)
>  {
>         struct drm_dp_sideband_msg_tx *txmsg;
>         struct drm_dp_mst_branch *mstb;
> @@ -1536,10 +1536,10 @@ static int drm_dp_create_payload_step1(struct drm_dp_mst_topology_mgr *mgr,
>         return 0;
>  }
>
> -int drm_dp_create_payload_step2(struct drm_dp_mst_topology_mgr *mgr,
> -                               struct drm_dp_mst_port *port,
> -                               int id,
> -                               struct drm_dp_payload *payload)
> +static int drm_dp_create_payload_step2(struct drm_dp_mst_topology_mgr *mgr,
> +                                      struct drm_dp_mst_port *port,
> +                                      int id,
> +                                      struct drm_dp_payload *payload)
>  {
>         int ret;
>         ret = drm_dp_payload_send_msg(mgr, port, id, port->vcpi.pbn);
> @@ -1549,10 +1549,10 @@ int drm_dp_create_payload_step2(struct drm_dp_mst_topology_mgr *mgr,
>         return ret;
>  }
>
> -int drm_dp_destroy_payload_step1(struct drm_dp_mst_topology_mgr *mgr,
> -                                struct drm_dp_mst_port *port,
> -                                int id,
> -                                struct drm_dp_payload *payload)
> +static int drm_dp_destroy_payload_step1(struct drm_dp_mst_topology_mgr *mgr,
> +                                       struct drm_dp_mst_port *port,
> +                                       int id,
> +                                       struct drm_dp_payload *payload)
>  {
>         DRM_DEBUG_KMS("\n");
>         /* its okay for these to fail */
> @@ -1565,9 +1565,9 @@ int drm_dp_destroy_payload_step1(struct drm_dp_mst_topology_mgr *mgr,
>         return 0;
>  }
>
> -int drm_dp_destroy_payload_step2(struct drm_dp_mst_topology_mgr *mgr,
> -                                int id,
> -                                struct drm_dp_payload *payload)
> +static int drm_dp_destroy_payload_step2(struct drm_dp_mst_topology_mgr *mgr,
> +                                       int id,
> +                                       struct drm_dp_payload *payload)
>  {
>         payload->payload_state = 0;
>         return 0;
> --
> 2.0.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel