[PATCH] drm/radeon: separate ring and IB handling
Alex Deucher
alexdeucher at gmail.com
Thu Jul 31 11:14:46 PDT 2014
On Thu, Jul 31, 2014 at 7:44 AM, Christian König
<deathsimple at vodafone.de> wrote:
> From: Christian König <christian.koenig at amd.com>
>
> Both on their own are complex enough.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
Applied to my 3.17 tree.
Alex
> ---
> drivers/gpu/drm/radeon/Makefile | 2 +-
> drivers/gpu/drm/radeon/radeon_ib.c | 319 +++++++++++++++++++++++++++++++++++
> drivers/gpu/drm/radeon/radeon_ring.c | 287 -------------------------------
> 3 files changed, 320 insertions(+), 288 deletions(-)
> create mode 100644 drivers/gpu/drm/radeon/radeon_ib.c
>
> diff --git a/drivers/gpu/drm/radeon/Makefile b/drivers/gpu/drm/radeon/Makefile
> index 1b04002..0013ad0 100644
> --- a/drivers/gpu/drm/radeon/Makefile
> +++ b/drivers/gpu/drm/radeon/Makefile
> @@ -80,7 +80,7 @@ radeon-y += radeon_device.o radeon_asic.o radeon_kms.o \
> r600_dpm.o rs780_dpm.o rv6xx_dpm.o rv770_dpm.o rv730_dpm.o rv740_dpm.o \
> rv770_smc.o cypress_dpm.o btc_dpm.o sumo_dpm.o sumo_smc.o trinity_dpm.o \
> trinity_smc.o ni_dpm.o si_smc.o si_dpm.o kv_smc.o kv_dpm.o ci_smc.o \
> - ci_dpm.o dce6_afmt.o radeon_vm.o radeon_ucode.o
> + ci_dpm.o dce6_afmt.o radeon_vm.o radeon_ucode.o radeon_ib.o
>
> # add async DMA block
> radeon-y += \
> diff --git a/drivers/gpu/drm/radeon/radeon_ib.c b/drivers/gpu/drm/radeon/radeon_ib.c
> new file mode 100644
> index 0000000..65b0c21
> --- /dev/null
> +++ b/drivers/gpu/drm/radeon/radeon_ib.c
> @@ -0,0 +1,319 @@
> +/*
> + * Copyright 2008 Advanced Micro Devices, Inc.
> + * Copyright 2008 Red Hat Inc.
> + * Copyright 2009 Jerome Glisse.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
> + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + *
> + * Authors: Dave Airlie
> + * Alex Deucher
> + * Jerome Glisse
> + * Christian König
> + */
> +#include <drm/drmP.h>
> +#include "radeon.h"
> +
> +/*
> + * IB
> + * IBs (Indirect Buffers) and areas of GPU accessible memory where
> + * commands are stored. You can put a pointer to the IB in the
> + * command ring and the hw will fetch the commands from the IB
> + * and execute them. Generally userspace acceleration drivers
> + * produce command buffers which are send to the kernel and
> + * put in IBs for execution by the requested ring.
> + */
> +static int radeon_debugfs_sa_init(struct radeon_device *rdev);
> +
> +/**
> + * radeon_ib_get - request an IB (Indirect Buffer)
> + *
> + * @rdev: radeon_device pointer
> + * @ring: ring index the IB is associated with
> + * @ib: IB object returned
> + * @size: requested IB size
> + *
> + * Request an IB (all asics). IBs are allocated using the
> + * suballocator.
> + * Returns 0 on success, error on failure.
> + */
> +int radeon_ib_get(struct radeon_device *rdev, int ring,
> + struct radeon_ib *ib, struct radeon_vm *vm,
> + unsigned size)
> +{
> + int r;
> +
> + r = radeon_sa_bo_new(rdev, &rdev->ring_tmp_bo, &ib->sa_bo, size, 256);
> + if (r) {
> + dev_err(rdev->dev, "failed to get a new IB (%d)\n", r);
> + return r;
> + }
> +
> + r = radeon_semaphore_create(rdev, &ib->semaphore);
> + if (r) {
> + return r;
> + }
> +
> + ib->ring = ring;
> + ib->fence = NULL;
> + ib->ptr = radeon_sa_bo_cpu_addr(ib->sa_bo);
> + ib->vm = vm;
> + if (vm) {
> + /* ib pool is bound at RADEON_VA_IB_OFFSET in virtual address
> + * space and soffset is the offset inside the pool bo
> + */
> + ib->gpu_addr = ib->sa_bo->soffset + RADEON_VA_IB_OFFSET;
> + } else {
> + ib->gpu_addr = radeon_sa_bo_gpu_addr(ib->sa_bo);
> + }
> + ib->is_const_ib = false;
> +
> + return 0;
> +}
> +
> +/**
> + * radeon_ib_free - free an IB (Indirect Buffer)
> + *
> + * @rdev: radeon_device pointer
> + * @ib: IB object to free
> + *
> + * Free an IB (all asics).
> + */
> +void radeon_ib_free(struct radeon_device *rdev, struct radeon_ib *ib)
> +{
> + radeon_semaphore_free(rdev, &ib->semaphore, ib->fence);
> + radeon_sa_bo_free(rdev, &ib->sa_bo, ib->fence);
> + radeon_fence_unref(&ib->fence);
> +}
> +
> +/**
> + * radeon_ib_schedule - schedule an IB (Indirect Buffer) on the ring
> + *
> + * @rdev: radeon_device pointer
> + * @ib: IB object to schedule
> + * @const_ib: Const IB to schedule (SI only)
> + *
> + * Schedule an IB on the associated ring (all asics).
> + * Returns 0 on success, error on failure.
> + *
> + * On SI, there are two parallel engines fed from the primary ring,
> + * the CE (Constant Engine) and the DE (Drawing Engine). Since
> + * resource descriptors have moved to memory, the CE allows you to
> + * prime the caches while the DE is updating register state so that
> + * the resource descriptors will be already in cache when the draw is
> + * processed. To accomplish this, the userspace driver submits two
> + * IBs, one for the CE and one for the DE. If there is a CE IB (called
> + * a CONST_IB), it will be put on the ring prior to the DE IB. Prior
> + * to SI there was just a DE IB.
> + */
> +int radeon_ib_schedule(struct radeon_device *rdev, struct radeon_ib *ib,
> + struct radeon_ib *const_ib)
> +{
> + struct radeon_ring *ring = &rdev->ring[ib->ring];
> + int r = 0;
> +
> + if (!ib->length_dw || !ring->ready) {
> + /* TODO: Nothings in the ib we should report. */
> + dev_err(rdev->dev, "couldn't schedule ib\n");
> + return -EINVAL;
> + }
> +
> + /* 64 dwords should be enough for fence too */
> + r = radeon_ring_lock(rdev, ring, 64 + RADEON_NUM_SYNCS * 8);
> + if (r) {
> + dev_err(rdev->dev, "scheduling IB failed (%d).\n", r);
> + return r;
> + }
> +
> + /* grab a vm id if necessary */
> + if (ib->vm) {
> + struct radeon_fence *vm_id_fence;
> + vm_id_fence = radeon_vm_grab_id(rdev, ib->vm, ib->ring);
> + radeon_semaphore_sync_to(ib->semaphore, vm_id_fence);
> + }
> +
> + /* sync with other rings */
> + r = radeon_semaphore_sync_rings(rdev, ib->semaphore, ib->ring);
> + if (r) {
> + dev_err(rdev->dev, "failed to sync rings (%d)\n", r);
> + radeon_ring_unlock_undo(rdev, ring);
> + return r;
> + }
> +
> + if (ib->vm)
> + radeon_vm_flush(rdev, ib->vm, ib->ring);
> +
> + if (const_ib) {
> + radeon_ring_ib_execute(rdev, const_ib->ring, const_ib);
> + radeon_semaphore_free(rdev, &const_ib->semaphore, NULL);
> + }
> + radeon_ring_ib_execute(rdev, ib->ring, ib);
> + r = radeon_fence_emit(rdev, &ib->fence, ib->ring);
> + if (r) {
> + dev_err(rdev->dev, "failed to emit fence for new IB (%d)\n", r);
> + radeon_ring_unlock_undo(rdev, ring);
> + return r;
> + }
> + if (const_ib) {
> + const_ib->fence = radeon_fence_ref(ib->fence);
> + }
> +
> + if (ib->vm)
> + radeon_vm_fence(rdev, ib->vm, ib->fence);
> +
> + radeon_ring_unlock_commit(rdev, ring);
> + return 0;
> +}
> +
> +/**
> + * radeon_ib_pool_init - Init the IB (Indirect Buffer) pool
> + *
> + * @rdev: radeon_device pointer
> + *
> + * Initialize the suballocator to manage a pool of memory
> + * for use as IBs (all asics).
> + * Returns 0 on success, error on failure.
> + */
> +int radeon_ib_pool_init(struct radeon_device *rdev)
> +{
> + int r;
> +
> + if (rdev->ib_pool_ready) {
> + return 0;
> + }
> +
> + if (rdev->family >= CHIP_BONAIRE) {
> + r = radeon_sa_bo_manager_init(rdev, &rdev->ring_tmp_bo,
> + RADEON_IB_POOL_SIZE*64*1024,
> + RADEON_GPU_PAGE_SIZE,
> + RADEON_GEM_DOMAIN_GTT,
> + RADEON_GEM_GTT_WC);
> + } else {
> + /* Before CIK, it's better to stick to cacheable GTT due
> + * to the command stream checking
> + */
> + r = radeon_sa_bo_manager_init(rdev, &rdev->ring_tmp_bo,
> + RADEON_IB_POOL_SIZE*64*1024,
> + RADEON_GPU_PAGE_SIZE,
> + RADEON_GEM_DOMAIN_GTT, 0);
> + }
> + if (r) {
> + return r;
> + }
> +
> + r = radeon_sa_bo_manager_start(rdev, &rdev->ring_tmp_bo);
> + if (r) {
> + return r;
> + }
> +
> + rdev->ib_pool_ready = true;
> + if (radeon_debugfs_sa_init(rdev)) {
> + dev_err(rdev->dev, "failed to register debugfs file for SA\n");
> + }
> + return 0;
> +}
> +
> +/**
> + * radeon_ib_pool_fini - Free the IB (Indirect Buffer) pool
> + *
> + * @rdev: radeon_device pointer
> + *
> + * Tear down the suballocator managing the pool of memory
> + * for use as IBs (all asics).
> + */
> +void radeon_ib_pool_fini(struct radeon_device *rdev)
> +{
> + if (rdev->ib_pool_ready) {
> + radeon_sa_bo_manager_suspend(rdev, &rdev->ring_tmp_bo);
> + radeon_sa_bo_manager_fini(rdev, &rdev->ring_tmp_bo);
> + rdev->ib_pool_ready = false;
> + }
> +}
> +
> +/**
> + * radeon_ib_ring_tests - test IBs on the rings
> + *
> + * @rdev: radeon_device pointer
> + *
> + * Test an IB (Indirect Buffer) on each ring.
> + * If the test fails, disable the ring.
> + * Returns 0 on success, error if the primary GFX ring
> + * IB test fails.
> + */
> +int radeon_ib_ring_tests(struct radeon_device *rdev)
> +{
> + unsigned i;
> + int r;
> +
> + for (i = 0; i < RADEON_NUM_RINGS; ++i) {
> + struct radeon_ring *ring = &rdev->ring[i];
> +
> + if (!ring->ready)
> + continue;
> +
> + r = radeon_ib_test(rdev, i, ring);
> + if (r) {
> + ring->ready = false;
> + rdev->needs_reset = false;
> +
> + if (i == RADEON_RING_TYPE_GFX_INDEX) {
> + /* oh, oh, that's really bad */
> + DRM_ERROR("radeon: failed testing IB on GFX ring (%d).\n", r);
> + rdev->accel_working = false;
> + return r;
> +
> + } else {
> + /* still not good, but we can live with it */
> + DRM_ERROR("radeon: failed testing IB on ring %d (%d).\n", i, r);
> + }
> + }
> + }
> + return 0;
> +}
> +
> +/*
> + * Debugfs info
> + */
> +#if defined(CONFIG_DEBUG_FS)
> +
> +static int radeon_debugfs_sa_info(struct seq_file *m, void *data)
> +{
> + struct drm_info_node *node = (struct drm_info_node *) m->private;
> + struct drm_device *dev = node->minor->dev;
> + struct radeon_device *rdev = dev->dev_private;
> +
> + radeon_sa_bo_dump_debug_info(&rdev->ring_tmp_bo, m);
> +
> + return 0;
> +
> +}
> +
> +static struct drm_info_list radeon_debugfs_sa_list[] = {
> + {"radeon_sa_info", &radeon_debugfs_sa_info, 0, NULL},
> +};
> +
> +#endif
> +
> +static int radeon_debugfs_sa_init(struct radeon_device *rdev)
> +{
> +#if defined(CONFIG_DEBUG_FS)
> + return radeon_debugfs_add_files(rdev, radeon_debugfs_sa_list, 1);
> +#else
> + return 0;
> +#endif
> +}
> diff --git a/drivers/gpu/drm/radeon/radeon_ring.c b/drivers/gpu/drm/radeon/radeon_ring.c
> index 20b0e4f..9c86ac9 100644
> --- a/drivers/gpu/drm/radeon/radeon_ring.c
> +++ b/drivers/gpu/drm/radeon/radeon_ring.c
> @@ -26,270 +26,8 @@
> * Jerome Glisse
> * Christian König
> */
> -#include <linux/seq_file.h>
> -#include <linux/slab.h>
> #include <drm/drmP.h>
> -#include <drm/radeon_drm.h>
> -#include "radeon_reg.h"
> #include "radeon.h"
> -#include "atom.h"
> -
> -/*
> - * IB
> - * IBs (Indirect Buffers) and areas of GPU accessible memory where
> - * commands are stored. You can put a pointer to the IB in the
> - * command ring and the hw will fetch the commands from the IB
> - * and execute them. Generally userspace acceleration drivers
> - * produce command buffers which are send to the kernel and
> - * put in IBs for execution by the requested ring.
> - */
> -static int radeon_debugfs_sa_init(struct radeon_device *rdev);
> -
> -/**
> - * radeon_ib_get - request an IB (Indirect Buffer)
> - *
> - * @rdev: radeon_device pointer
> - * @ring: ring index the IB is associated with
> - * @ib: IB object returned
> - * @size: requested IB size
> - *
> - * Request an IB (all asics). IBs are allocated using the
> - * suballocator.
> - * Returns 0 on success, error on failure.
> - */
> -int radeon_ib_get(struct radeon_device *rdev, int ring,
> - struct radeon_ib *ib, struct radeon_vm *vm,
> - unsigned size)
> -{
> - int r;
> -
> - r = radeon_sa_bo_new(rdev, &rdev->ring_tmp_bo, &ib->sa_bo, size, 256);
> - if (r) {
> - dev_err(rdev->dev, "failed to get a new IB (%d)\n", r);
> - return r;
> - }
> -
> - r = radeon_semaphore_create(rdev, &ib->semaphore);
> - if (r) {
> - return r;
> - }
> -
> - ib->ring = ring;
> - ib->fence = NULL;
> - ib->ptr = radeon_sa_bo_cpu_addr(ib->sa_bo);
> - ib->vm = vm;
> - if (vm) {
> - /* ib pool is bound at RADEON_VA_IB_OFFSET in virtual address
> - * space and soffset is the offset inside the pool bo
> - */
> - ib->gpu_addr = ib->sa_bo->soffset + RADEON_VA_IB_OFFSET;
> - } else {
> - ib->gpu_addr = radeon_sa_bo_gpu_addr(ib->sa_bo);
> - }
> - ib->is_const_ib = false;
> -
> - return 0;
> -}
> -
> -/**
> - * radeon_ib_free - free an IB (Indirect Buffer)
> - *
> - * @rdev: radeon_device pointer
> - * @ib: IB object to free
> - *
> - * Free an IB (all asics).
> - */
> -void radeon_ib_free(struct radeon_device *rdev, struct radeon_ib *ib)
> -{
> - radeon_semaphore_free(rdev, &ib->semaphore, ib->fence);
> - radeon_sa_bo_free(rdev, &ib->sa_bo, ib->fence);
> - radeon_fence_unref(&ib->fence);
> -}
> -
> -/**
> - * radeon_ib_schedule - schedule an IB (Indirect Buffer) on the ring
> - *
> - * @rdev: radeon_device pointer
> - * @ib: IB object to schedule
> - * @const_ib: Const IB to schedule (SI only)
> - *
> - * Schedule an IB on the associated ring (all asics).
> - * Returns 0 on success, error on failure.
> - *
> - * On SI, there are two parallel engines fed from the primary ring,
> - * the CE (Constant Engine) and the DE (Drawing Engine). Since
> - * resource descriptors have moved to memory, the CE allows you to
> - * prime the caches while the DE is updating register state so that
> - * the resource descriptors will be already in cache when the draw is
> - * processed. To accomplish this, the userspace driver submits two
> - * IBs, one for the CE and one for the DE. If there is a CE IB (called
> - * a CONST_IB), it will be put on the ring prior to the DE IB. Prior
> - * to SI there was just a DE IB.
> - */
> -int radeon_ib_schedule(struct radeon_device *rdev, struct radeon_ib *ib,
> - struct radeon_ib *const_ib)
> -{
> - struct radeon_ring *ring = &rdev->ring[ib->ring];
> - int r = 0;
> -
> - if (!ib->length_dw || !ring->ready) {
> - /* TODO: Nothings in the ib we should report. */
> - dev_err(rdev->dev, "couldn't schedule ib\n");
> - return -EINVAL;
> - }
> -
> - /* 64 dwords should be enough for fence too */
> - r = radeon_ring_lock(rdev, ring, 64 + RADEON_NUM_SYNCS * 8);
> - if (r) {
> - dev_err(rdev->dev, "scheduling IB failed (%d).\n", r);
> - return r;
> - }
> -
> - /* grab a vm id if necessary */
> - if (ib->vm) {
> - struct radeon_fence *vm_id_fence;
> - vm_id_fence = radeon_vm_grab_id(rdev, ib->vm, ib->ring);
> - radeon_semaphore_sync_to(ib->semaphore, vm_id_fence);
> - }
> -
> - /* sync with other rings */
> - r = radeon_semaphore_sync_rings(rdev, ib->semaphore, ib->ring);
> - if (r) {
> - dev_err(rdev->dev, "failed to sync rings (%d)\n", r);
> - radeon_ring_unlock_undo(rdev, ring);
> - return r;
> - }
> -
> - if (ib->vm)
> - radeon_vm_flush(rdev, ib->vm, ib->ring);
> -
> - if (const_ib) {
> - radeon_ring_ib_execute(rdev, const_ib->ring, const_ib);
> - radeon_semaphore_free(rdev, &const_ib->semaphore, NULL);
> - }
> - radeon_ring_ib_execute(rdev, ib->ring, ib);
> - r = radeon_fence_emit(rdev, &ib->fence, ib->ring);
> - if (r) {
> - dev_err(rdev->dev, "failed to emit fence for new IB (%d)\n", r);
> - radeon_ring_unlock_undo(rdev, ring);
> - return r;
> - }
> - if (const_ib) {
> - const_ib->fence = radeon_fence_ref(ib->fence);
> - }
> -
> - if (ib->vm)
> - radeon_vm_fence(rdev, ib->vm, ib->fence);
> -
> - radeon_ring_unlock_commit(rdev, ring);
> - return 0;
> -}
> -
> -/**
> - * radeon_ib_pool_init - Init the IB (Indirect Buffer) pool
> - *
> - * @rdev: radeon_device pointer
> - *
> - * Initialize the suballocator to manage a pool of memory
> - * for use as IBs (all asics).
> - * Returns 0 on success, error on failure.
> - */
> -int radeon_ib_pool_init(struct radeon_device *rdev)
> -{
> - int r;
> -
> - if (rdev->ib_pool_ready) {
> - return 0;
> - }
> -
> - if (rdev->family >= CHIP_BONAIRE) {
> - r = radeon_sa_bo_manager_init(rdev, &rdev->ring_tmp_bo,
> - RADEON_IB_POOL_SIZE*64*1024,
> - RADEON_GPU_PAGE_SIZE,
> - RADEON_GEM_DOMAIN_GTT,
> - RADEON_GEM_GTT_WC);
> - } else {
> - /* Before CIK, it's better to stick to cacheable GTT due
> - * to the command stream checking
> - */
> - r = radeon_sa_bo_manager_init(rdev, &rdev->ring_tmp_bo,
> - RADEON_IB_POOL_SIZE*64*1024,
> - RADEON_GPU_PAGE_SIZE,
> - RADEON_GEM_DOMAIN_GTT, 0);
> - }
> - if (r) {
> - return r;
> - }
> -
> - r = radeon_sa_bo_manager_start(rdev, &rdev->ring_tmp_bo);
> - if (r) {
> - return r;
> - }
> -
> - rdev->ib_pool_ready = true;
> - if (radeon_debugfs_sa_init(rdev)) {
> - dev_err(rdev->dev, "failed to register debugfs file for SA\n");
> - }
> - return 0;
> -}
> -
> -/**
> - * radeon_ib_pool_fini - Free the IB (Indirect Buffer) pool
> - *
> - * @rdev: radeon_device pointer
> - *
> - * Tear down the suballocator managing the pool of memory
> - * for use as IBs (all asics).
> - */
> -void radeon_ib_pool_fini(struct radeon_device *rdev)
> -{
> - if (rdev->ib_pool_ready) {
> - radeon_sa_bo_manager_suspend(rdev, &rdev->ring_tmp_bo);
> - radeon_sa_bo_manager_fini(rdev, &rdev->ring_tmp_bo);
> - rdev->ib_pool_ready = false;
> - }
> -}
> -
> -/**
> - * radeon_ib_ring_tests - test IBs on the rings
> - *
> - * @rdev: radeon_device pointer
> - *
> - * Test an IB (Indirect Buffer) on each ring.
> - * If the test fails, disable the ring.
> - * Returns 0 on success, error if the primary GFX ring
> - * IB test fails.
> - */
> -int radeon_ib_ring_tests(struct radeon_device *rdev)
> -{
> - unsigned i;
> - int r;
> -
> - for (i = 0; i < RADEON_NUM_RINGS; ++i) {
> - struct radeon_ring *ring = &rdev->ring[i];
> -
> - if (!ring->ready)
> - continue;
> -
> - r = radeon_ib_test(rdev, i, ring);
> - if (r) {
> - ring->ready = false;
> - rdev->needs_reset = false;
> -
> - if (i == RADEON_RING_TYPE_GFX_INDEX) {
> - /* oh, oh, that's really bad */
> - DRM_ERROR("radeon: failed testing IB on GFX ring (%d).\n", r);
> - rdev->accel_working = false;
> - return r;
> -
> - } else {
> - /* still not good, but we can live with it */
> - DRM_ERROR("radeon: failed testing IB on ring %d (%d).\n", i, r);
> - }
> - }
> - }
> - return 0;
> -}
>
> /*
> * Rings
> @@ -805,22 +543,6 @@ static struct drm_info_list radeon_debugfs_ring_info_list[] = {
> {"radeon_ring_vce2", radeon_debugfs_ring_info, 0, &si_vce2_index},
> };
>
> -static int radeon_debugfs_sa_info(struct seq_file *m, void *data)
> -{
> - struct drm_info_node *node = (struct drm_info_node *) m->private;
> - struct drm_device *dev = node->minor->dev;
> - struct radeon_device *rdev = dev->dev_private;
> -
> - radeon_sa_bo_dump_debug_info(&rdev->ring_tmp_bo, m);
> -
> - return 0;
> -
> -}
> -
> -static struct drm_info_list radeon_debugfs_sa_list[] = {
> - {"radeon_sa_info", &radeon_debugfs_sa_info, 0, NULL},
> -};
> -
> #endif
>
> static int radeon_debugfs_ring_init(struct radeon_device *rdev, struct radeon_ring *ring)
> @@ -842,12 +564,3 @@ static int radeon_debugfs_ring_init(struct radeon_device *rdev, struct radeon_ri
> #endif
> return 0;
> }
> -
> -static int radeon_debugfs_sa_init(struct radeon_device *rdev)
> -{
> -#if defined(CONFIG_DEBUG_FS)
> - return radeon_debugfs_add_files(rdev, radeon_debugfs_sa_list, 1);
> -#else
> - return 0;
> -#endif
> -}
> --
> 1.9.1
>
More information about the dri-devel
mailing list