[PATCH] drm/exynos: add phy settings for RB resolutions

Tomasz Figa t.figa at samsung.com
Wed Mar 12 08:26:32 PDT 2014


Hi Shirish,

On 10.03.2014 15:17, Shirish S wrote:
> below is list of pixel clocks and resoluitons
> this patch adds:
>
> 71000000  - 1280x800 at 60Hz RB
> 73250000  - 800x600 at 120Hz RB
> 88750000  - 1440x900 at 60Hz RB
> 115500000 - 1024x768 at 120Hz RB
> 119000000 - 1680x1050 at 60Hz RB
>
> without these pixel clocks' support the mentioned
> resolutions fail to be detected in exynos5250.

This commit message is poorly written. Please start sentences with 
capital letters and check spelling before sending.

Here follows an example of commit message for this patch:

8<---

This patch adds several new pixel clock settings for HDMI PHY v14 
(Exynos5250). Without them following display modes cannot be supported:

  71000000 Hz - 1280x800 at 60Hz RB
  73250000 Hz - 800x600 at 120Hz RB
  88750000 Hz - 1440x900 at 60Hz RB
115500000 Hz - 1024x768 at 120Hz RB
119000000 Hz - 1680x1050 at 60Hz RB

--->8

>
> Signed-off-by: Shirish S <s.shirish at samsung.com>
> ---
>   drivers/gpu/drm/exynos/exynos_hdmi.c |   45 ++++++++++++++++++++++++++++++++++
>   1 file changed, 45 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index c021ddc..650ce48 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -303,6 +303,24 @@ static const struct hdmiphy_config hdmiphy_v14_configs[] = {
>   		},
>   	},
>   	{
> +		.pixel_clock = 71000000,
> +		.conf = {
> +			0x01, 0x91, 0x1E, 0x15, 0x40, 0x3C, 0xCE, 0x08,

Lowercase is preferred by kernel coding style for hexadecimal values.

Best regards,
Tomasz


More information about the dri-devel mailing list