[RFC] drm + i915 DP MST code preview

Dave Airlie airlied at gmail.com
Thu May 8 00:32:53 PDT 2014


On 8 May 2014 17:24, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Thu, May 08, 2014 at 11:56:02AM +1000, Dave Airlie wrote:
>> I've pushed a branch of -modesetting to
>>
>> http://cgit.freedesktop.org/~airlied/xf86-video-modesetting/log/?h=dp-mst
>
> In parse_path_blob():
> char conn_id[5];
>
> len = conn - (blob_data + 4);
> if (len + 1> 5) return -1;
>
> memcpy(conn_id, blob_data + 4, len);
> conn_id[len + 1] = '\0';
>         ^^^^^^^ should just be len.

Nice catch, thanks, I'll fix that,

The kernel side for this along with even more locking and refcounting
fixes is in
http://cgit.freedesktop.org/~airlied/linux/log/?h=drm-i915-mst-support

Dave.


More information about the dri-devel mailing list