[PATCH 06/17] drm: helpers to find mode objects

Daniel Vetter daniel at ffwll.ch
Mon May 26 01:55:38 PDT 2014


On Mon, May 26, 2014 at 10:37 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Sat, May 24, 2014 at 02:30:15PM -0400, Rob Clark wrote:
>> Add a few more useful helpers to find mode objects.
>>
>> Signed-off-by: Rob Clark <robdclark at gmail.com>
>
> There's a pile more in drivers for these. I like this, but imo we should
> also convert drivers while at it. Also, docbook is missing. And since it's
> a cleanup I think it's better to do this first, directly on top of
> drm-next. The patch itself looks good.

Aside: This is a pretty perfect case for coccinelle since it'll match
object_find users no matter how crazily they're split up. And you can
remove the unused local variable with it too (but that part is a bit
more fuzz).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list