[PATCH 10/10] drm/exynos: atomic dpms support

Gustavo Padovan gustavo at padovan.org
Fri Apr 3 08:06:20 PDT 2015


Hi Joonyoung,

2015-04-03 Joonyoung Shim <jy0922.shim at samsung.com>:

> Hi,
>  
> >>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> >>> index e71e331..e0b085b 100644
> >>> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> >>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> >>> @@ -275,9 +275,6 @@ int exynos_drm_fbdev_init(struct drm_device *dev)
> >>>  
> >>>  	}
> >>>  
> >>> -	/* disable all the possible outputs/crtcs before entering KMS mode */
> >>> -	drm_helper_disable_unused_functions(dev);
> >>> -
> >>
> >> I think this is not related with atomic dpms support, if this needs,
> >> could you make another patch?
> > 
> > Yes, it is, once you port exynos to use atomic dpms we start getting warning
> > from this functions, the correct solution is to remove it. Other subsystems
> > followed the same approach.
> 
> As i said, the warning comes from changes of this patch.
> 
> From rcar-du driver, it was handled to a separate patch.
> 
> http://www.spinics.net/lists/linux-sh/msg40384.html

Right, I think make this a new patch is no harm and will make things more clear.

> > 
> > I'm sending an updated patch set in a bit.
> 
> OK, but i didn't get your updated patch 10/10 yet. Could you resend it?

No, I did a mistake with git send-email. Used 000*.patch to send the patches.
That excluded the 0010 one. So I resend a new patchset with the change above
and make sure I don't make the same mistake again.

	Gustavo


More information about the dri-devel mailing list