[PATCH 2/3] drm/msm: wait_for_completion_timeout return is never negative

Nicholas Mc Guire hofrat at osadl.org
Sat Apr 11 06:10:37 PDT 2015


wait_for_completion_timeout returns >= 0 but never
negative  - so the error check should be against equality
to 0 not <= 0.

Signed-off-by: Nicholas Mc Guire <hofrat at osadl.org>
---

This was compile tested with qcom_defconfig +
CONFIG_DRM=m (implies CONFIG_DRM_MSM=m)

Patch is against 4.0-rc7 (localversion-next is -next-20150410)

 drivers/gpu/drm/msm/edp/edp_ctrl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c b/drivers/gpu/drm/msm/edp/edp_ctrl.c
index 831acd6..9ef361c 100644
--- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
+++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
@@ -1032,7 +1032,7 @@ static void edp_ctrl_off_worker(struct work_struct *work)
 
 	time_left = wait_for_completion_timeout(&ctrl->idle_comp,
 						msecs_to_jiffies(500));
-	if (time_left <= 0)
+	if (!time_left)
 		DBG("%s: idle pattern timedout, %lu\n",
 				__func__, time_left);
 
-- 
1.7.10.4



More information about the dri-devel mailing list